Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): remove unnecessary exports #8469

Merged
merged 1 commit into from
Feb 3, 2025
Merged

chore(core): remove unnecessary exports #8469

merged 1 commit into from
Feb 3, 2025

Conversation

pedrobonamin
Copy link
Contributor

Description

Removes unnecessary exports and removes the @internal tag from the releases telemetry events to avoid exporting them in the future by mistake.

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin requested review from a team as code owners January 31, 2025 16:23
@pedrobonamin pedrobonamin requested review from ricokahler and removed request for a team January 31, 2025 16:23
@vercel Vercel
Copy link

vercel bot commented Jan 31, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 4:30pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 4:30pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 4:30pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jan 31, 2025 4:30pm
test-next-studio ⬜️ Ignored (Inspect) Jan 31, 2025 4:30pm

@pedrobonamin pedrobonamin requested review from a team and RitaDias and removed request for a team and ricokahler January 31, 2025 16:23
@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

Component Testing Report Updated Jan 31, 2025 4:34 PM (UTC)

❌ Failed Tests (2) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 5s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 20s 5 0 1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 31s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 2s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 2m 24s 20 0 1
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@github-actions GitHub Actions
Copy link
Contributor

⚡️ Editor Performance Report

Updated Fri, 31 Jan 2025 16:36:22 GMT

Benchmark reference
latency of sanity@latest		 experiment
latency of this branch		 Δ (%)
latency difference
article (title) 23.3 efps (43ms) 23.3 efps (43ms) +0ms (-/-%) ✅
article (body) 63.1 efps (16ms) 63.3 efps (16ms) -0ms (-/-%) ✅
article (string inside object) 25.0 efps (40ms) 24.4 efps (41ms) +1ms (+2.5%) ✅
article (string inside array) 23.5 efps (43ms) 23.3 efps (43ms) +1ms (+1.2%) ✅
recipe (name) 50.0 efps (20ms) 50.0 efps (20ms) +0ms (-/-%) ✅
recipe (description) 55.6 efps (18ms) 55.6 efps (18ms) +0ms (-/-%) ✅
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%) ✅
synthetic (title) 17.5 efps (57ms) 17.4 efps (58ms) +1ms (+0.9%) ✅
synthetic (string inside object) 18.5 efps (54ms) 18.3 efps (55ms) +1ms (+0.9%) ✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 43ms 68ms 81ms 466ms 1034ms 12.0s
article (body) 16ms 20ms 30ms 182ms 462ms 5.9s
article (string inside object) 40ms 42ms 52ms 236ms 311ms 7.1s
article (string inside array) 43ms 45ms 52ms 160ms 336ms 7.4s
recipe (name) 20ms 21ms 23ms 45ms 0ms 6.5s
recipe (description) 18ms 20ms 24ms 41ms 1ms 4.7s
recipe (instructions) 5ms 7ms 8ms 32ms 0ms 3.1s
synthetic (title) 57ms 61ms 86ms 331ms 1280ms 12.5s
synthetic (string inside object) 54ms 58ms 73ms 339ms 768ms 8.8s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 43ms 52ms 75ms 539ms 1001ms 10.9s
article (body) 16ms 19ms 23ms 167ms 234ms 6.0s
article (string inside object) 41ms 44ms 46ms 168ms 197ms 7.1s
article (string inside array) 43ms 45ms 48ms 150ms 429ms 7.5s
recipe (name) 20ms 21ms 24ms 38ms 0ms 6.9s
recipe (description) 18ms 19ms 21ms 31ms 0ms 4.4s
recipe (instructions) 5ms 6ms 7ms 9ms 0ms 3.1s
synthetic (title) 58ms 61ms 77ms 435ms 1295ms 18.5s
synthetic (string inside object) 55ms 58ms 66ms 467ms 1726ms 9.6s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

RitaDias
RitaDias approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@RitaDias RitaDias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!!

@pedrobonamin pedrobonamin merged commit d1eb0de into feat/content-releases Feb 3, 2025
56 checks passed
@pedrobonamin pedrobonamin deleted the corel-exports-cleanup branch February 3, 2025 08:14
pedrobonamin added a commit that referenced this pull request Feb 4, 2025
@pedrobonamin
chore(core): remove unnecessary exports (#8469)
f8d8f56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RitaDias RitaDias RitaDias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedrobonamin @RitaDias